Multi value support #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smelukov
force-pushed
the
multi-params
branch
2 times, most recently
from
2ac9aac to
c2be7e4
Compare
lahmatiy
reviewed
Jun 8, 2017
| @@ -719,27 +721,21 @@ Command.prototype = { | |||
| prevCommand.delegate_(command); | |||
|
|
|||
| // apply beforeInit options | |||
| command.setOptions( | |||
There was a problem hiding this comment.
With this change, normalization for --foo bar baz --foo quux will run 2 times:
[foo, bar][quux]
For every passed option with the same name.
Without it only 1 time: [foo, bar, quux] for all passed options with the same name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.