Changing flask-security to flask-security-too #162
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I opened this new branch because the previous got messed up during a rebase.
The currently used flask-security package is no longer supported (latest change is 2,5 years old), flask-security-too is the maintained up-to-date version of it.
Previously we talked about @gammaw that introducing the authentication made the frontend page is a bit slower.
This new security package offers some performance boost with version 3.1.0 and 3.2.0, for these uplifts we need a modification which looks like a DB change but it's not that. I checked the use of lazy parameter according to this article and it looks like we don't use it directly anywhere in the code, so no other changes needed.
We agreed that we should do some performance measurement before these upgrades:
I extended the CI tests with the robustness/benchmark part, you can see the results for flask-security-too version 3.0.2 here and 3.2.0 here, it wasn't a big performance break-through :(