New endpoint for analytics #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to get uploaded items' count in last x days
to get uploaded items' count in last x days
…/github.com/lahmacunradio/arcsi into dev/daily-weekly-upload-stats-for-analytics
updated swagger docs added constraints on API's variables
gammaw
requested changes
Dec 8, 2022
arcsi/api/data.py
Outdated
| episodes_count = Item.query.filter( | ||
| given_date - timedelta(days=last_days) <= Item.play_date | ||
| ).filter(Item.play_date <= datetime.today() | ||
| ).filter(Item.archived == True).count() |
There was a problem hiding this comment.
@tuz666 it seems we don't count live episods that we haven't archived yet. I think we should, cause they have been aired too.
There was a problem hiding this comment.
True, I forgot about them, fixed this in the latest commit!
| @@ -97,7 +97,7 @@ def list_items_latest(): | |||
| return items_archive_schema.dumps(items.items) | |||
|
|
|||
|
|
|||
| @arcsi.route("/item/<id>", methods=["GET"]) | |||
| @arcsi.route("/item/<int:id>", methods=["GET"]) | |||
There was a problem hiding this comment.
@tuz666 if possible, in the future, add such fixes separately (on a new branch/PR) or at least via separate commits.
There was a problem hiding this comment.
Yepp, I will do that way next time!
add live episodes number too
gammaw
approved these changes
Dec 8, 2022
| @@ -22,7 +22,7 @@ def uploaded_episodes_in_last_x_days(): | |||
| episodes_count = Item.query.filter( | |||
| given_date - timedelta(days=last_days) <= Item.play_date | |||
| ).filter(Item.play_date <= datetime.today() | |||
| ).filter(Item.archived == True).count() | |||
There was a problem hiding this comment.
@tuz666 elegant! Adding features by deleting code ;)
There was a problem hiding this comment.
:DD thanks for review!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added 2 new API endpoints which returns the sum of the uploaded items during the last x days/weeks from the given date.
Introduced new statistics related view pages on Arcsi UI, to be able to reach these info without Postman requests.
Updated the Swagger docs according to this.
Also added some constraints on API URL's variables, in order to prevent incorrect API calls (changes in item.py, show.py, user.py).