-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extraneous sort features in Parascope search #59
Comments
@mfenner what do you think about this? should we leave them in to show users what they COULD do if there was data available? or remove them since they are non-functional given lack of data? |
I think you could adapt this to the data available, we already have Wikipedia, DataCite and a few others, with more to come. Similar to the sort you can do at http://det.labs.crossref.org/articles |
Yes it should adapt, but doesn't right now. Bear in mind this is sorting based on the CrossRef API, not on ALM. Previously with PLOS, it was possible to sort on ALM, as some of that data is also in Solr. |
Good point. It sounds as if it would be a bigger effort, so maybe this can come later and we focus on sort by date ascending and descending for now. There is a bug in that the sort order is appended to the URL rather than sort replaced. Leading to something like http://almreports.crowdometer.org/search?utf8=%E2%9C%93&everything=cancer&commit=Search&sort=publication_date%20desc&sort=publication_date%20desc&sort=publication_date%20asc&sort=publication_date%20desc |
btw, sort is broken in ALM Reports. could this be ALM Reports or is it Solr? |
@mfenner with regards to the bug of appending the @jenniferlin15 Can you say a bit more about what search you did and what the expected sort results would look like vs. how they look like now? Sort seems to be working fine for me locally in PLOS mode and on first glance seems to be working fine on almreports.plos.org too. |
Sorting results is broken on ALM Reports. See screen shot. I searched for Yeast in keyword. Then I sorted results for Most Tweeted. If you click into the articles, you'll see that it did not sort correctly. Digging around, it looks like it sorts correctly by date and views but not the rest of the ALM sort elements. Most bookmarked, cited, shared, and tweeted are all broken. |
Looks like the Most cited, Most bookmarked, Most shared and Most Tweeted sorts are not working as expected. I'm not sure why these would break while other sorts continue to work. It looks like this is a Solr issue though, given that this search produces the same (incorrect) results: All alm_twitterCounts seem to be zero. All of the other fields that the sort relies on seem to be zero too, e.g. sorting by scopusCiteCount (and showing all alm fields): The result is:
Notice the zeros for |
… sorting. Also fixes the repeated sort parameter in URL, by using the queryString module and changing the sort parameter instead of appending it. Closes #59.
… sorting. Also fixes the repeated sort parameter in URL, by using the queryString module and changing the sort parameter instead of appending it. Closes #59.
The sort selection in Parascope have elements beyond the data available. We should disable them until it can be made functional. Extraneous ones include:
The text was updated successfully, but these errors were encountered: