Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extraneous sort features in Parascope search #59

Closed
jenniferlin15 opened this issue Oct 7, 2014 · 9 comments · Fixed by #74
Closed

Extraneous sort features in Parascope search #59

jenniferlin15 opened this issue Oct 7, 2014 · 9 comments · Fixed by #74
Labels

Comments

@jenniferlin15
Copy link

The sort selection in Parascope have elements beyond the data available. We should disable them until it can be made functional. Extraneous ones include:

  • Most views
  • Most views in 30 days
  • Most shared in social media
  • Most tweeted.
@jenniferlin15
Copy link
Author

@mfenner what do you think about this? should we leave them in to show users what they COULD do if there was data available? or remove them since they are non-functional given lack of data?

@mfenner
Copy link
Member

mfenner commented Oct 7, 2014

I think you could adapt this to the data available, we already have Wikipedia, DataCite and a few others, with more to come. Similar to the sort you can do at http://det.labs.crossref.org/articles

@jenniferlin15
Copy link
Author

okay, let's go with that approach. i have attached a screen shot of all the sort elements that we should use instead. for each of the sources, we will sort based on highest count (in descending order). (users won't need to sort off of lowest so no need to specify in the title.)
sort

@jure
Copy link
Contributor

jure commented Oct 7, 2014

Yes it should adapt, but doesn't right now. Bear in mind this is sorting based on the CrossRef API, not on ALM. Previously with PLOS, it was possible to sort on ALM, as some of that data is also in Solr.

@mfenner
Copy link
Member

mfenner commented Oct 7, 2014

Good point. It sounds as if it would be a bigger effort, so maybe this can come later and we focus on sort by date ascending and descending for now.

There is a bug in that the sort order is appended to the URL rather than sort replaced. Leading to something like http://almreports.crowdometer.org/search?utf8=%E2%9C%93&everything=cancer&commit=Search&sort=publication_date%20desc&sort=publication_date%20desc&sort=publication_date%20asc&sort=publication_date%20desc

@jenniferlin15
Copy link
Author

btw, sort is broken in ALM Reports. could this be ALM Reports or is it Solr?

@jure
Copy link
Contributor

jure commented Oct 7, 2014

@mfenner with regards to the bug of appending the sort parameter, that's an old one, and not something that could've broken sort recently: https://github.com/articlemetrics/alm-report/blame/master/app/assets/javascripts/script.js#L768-L769

@jenniferlin15 Can you say a bit more about what search you did and what the expected sort results would look like vs. how they look like now? Sort seems to be working fine for me locally in PLOS mode and on first glance seems to be working fine on almreports.plos.org too.

@jenniferlin15
Copy link
Author

Sorting results is broken on ALM Reports. See screen shot. I searched for Yeast in keyword. Then I sorted results for Most Tweeted. If you click into the articles, you'll see that it did not sort correctly.

Digging around, it looks like it sorts correctly by date and views but not the rest of the ALM sort elements. Most bookmarked, cited, shared, and tweeted are all broken.

sprtbug

@jure
Copy link
Contributor

jure commented Oct 8, 2014

Looks like the Most cited, Most bookmarked, Most shared and Most Tweeted sorts are not working as expected. I'm not sure why these would break while other sorts continue to work.

It looks like this is a Solr issue though, given that this search produces the same (incorrect) results:
http://api.plos.org/search?q=everything%3Acancer&fq=doc_type:full&fq=!article_type_facet:%22Issue%20Image%22&fl=id,pmid,publication_date,received_date,accepted_date,title,cross_published_journal_name,author_display,editor_display,article_type,affiliate,subject,financial_disclosure,alm_twitterCount,counter_total_all&wt=json&facet=false&rows=25&sort=alm_twitterCount%20desc&hl=false

All alm_twitterCounts seem to be zero.

All of the other fields that the sort relies on seem to be zero too, e.g. sorting by scopusCiteCount (and showing all alm fields):
http://api.plos.org/search?q=everything%3Acancer&fq=doc_type:full&fq=!article_type_facet:%22Issue%20Image%22&fl=id,pmid,publication_date,received_date,accepted_date,title,cross_published_journal_name,author_display,editor_display,article_type,affiliate,subject,financial_disclosure,alm_twitterCount,counter_total_all,alm_facebookCount,alm_citeulikeCount,alm_mendeleyCount,alm_scopusCiteCount&wt=json&facet=false&rows=25&sort=alm_scopusCiteCount%20desc&hl=false

The result is:

{
    "response": {
        "numFound": 47698,
        "start": 0,
        "docs": [
            {
                "id": "10.1371/journal.pbio.0050080",
                "cross_published_journal_name": [
                    "PLOS Biology"
                ],
                "alm_scopusCiteCount": 0,
                "alm_citeulikeCount": 0,
                "alm_mendeleyCount": 0,
                "alm_twitterCount": 0,
                "alm_facebookCount": 0,
                "pmid": "",
                "counter_total_all": 3357,
                "subject": [
                    "/Biology and life sciences/Genetics/Mutation",
                    "/Research and analysis methods/Model organisms/Animal models/Chickens",
                    "/Biology and life sciences/Agriculture/Livestock/Poultry/Chickens",
                    "/Medicine and health sciences/Physiology/Immune physiology/Antibodies",
                    "/Biology and life sciences/Immunology/Immune system proteins/Antibodies",
                    "/Biology and life sciences/Organisms/Animals/Vertebrates/Birds/Poultry/Chickens",
                    "/Biology and life sciences/Biochemistry/DNA/DNA recombination/Gene conversion",
                    "/Biology and life sciences/Genetics/DNA/DNA recombination/Gene conversion",
                    "/Biology and life sciences/Physiology/Immune physiology/Antibodies",
                    "/Biology and life sciences/Biochemistry/Proteins/Immune system proteins/Antibodies",
                    "/Biology and life sciences/Biochemistry/DNA",
                    "/Biology and life sciences/Genetics/DNA",
                    "/Biology and life sciences/Cell biology/Cellular types/Animal cells/Immune cells/Antibody-producing cells/B cells",
                    "/Medicine and health sciences/Immunology/Immune system proteins/Antibodies",
                    "/Medicine and health sciences/Immunology/Immune cells/White blood cells/B cells",
                    "/Biology and life sciences/Organisms/Animals/Vertebrates/Birds/Chickens",
                    "/Biology and life sciences/Biochemistry/DNA/DNA repair/Non-homologous end joining",
                    "/Biology and life sciences/Cell biology/Cellular types/Animal cells/Immune cells/White blood cells/B cells",
                    "/Biology and life sciences/Genetics/Mutation/Point mutation",
                    "/Biology and life sciences/Genetics/DNA/DNA repair/Non-homologous end joining",
                    "/Biology and life sciences/Immunology/Immune cells/White blood cells/B cells",
                    "/Biology and life sciences/Cell biology/Cellular types/Animal cells/Blood cells/White blood cells/B cells",
                    "/Biology and life sciences/Immunology/Immune cells/Antibody-producing cells/B cells",
                    "/Medicine and health sciences/Immunology/Immune cells/Antibody-producing cells/B cells"
                ],
                "publication_date": "2007-03-13T00:00:00Z",
                "received_date": "2006-06-13T00:00:00Z",
                "accepted_date": "2007-01-18T00:00:00Z",
                "article_type": "Research Article",
                "author_display": [
                    "Adam J. L Cook",
                    "Joanna M Raftery",
                    "K. K. Edwin Lau",
                    "Andrew Jessup",
                    "Reuben S Harris",
                    "Shunichi Takeda",
                    "Christopher J Jolly"
                ],
                "editor_display": [
                    "David Nemazee"
                ],
                "affiliate": [
                    "Centenary Institute and University of Sydney Faculty of Medicine, Sydney, New South Wales, Australia",
                    "Department of Biochemistry, Molecular Biology, and Biophysics, University of Minnesota, Minneapolis, Minnesota, United States of America",
                    "Institute for Molecular Virology, University of Minnesota, Minneapolis, Minnesota, United States of America",
                    "Department of Radiation Genetics, Kyoto University School of Medicine, Kyoto, Japan"
                ],
                "financial_disclosure": "This work was funded by a fellowship from the National Health and Medical Research Council to CJJ and by a scholarship from the Cancer Institute NSW to AJLC. AJLC was a recipient of an Australian Postgraduate Award.",
                "title": "DNA-Dependent Protein Kinase Inhibits AID-Induced Antibody Gene Conversion"
            }

Notice the zeros for alm_*. Given this and the fact that other non-ALM sorts are working, this looks like a Solr issue.

jure added a commit that referenced this issue Oct 12, 2014
… sorting. Also fixes the repeated sort parameter in URL, by using the queryString module and changing the sort parameter instead of appending it. Closes #59.
jure added a commit that referenced this issue Oct 12, 2014
… sorting. Also fixes the repeated sort parameter in URL, by using the queryString module and changing the sort parameter instead of appending it. Closes #59.
@jure jure closed this as completed in #74 Oct 12, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants