Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Select all articles' is not working #58

Closed
jenniferlin15 opened this issue Oct 7, 2014 · 3 comments
Closed

'Select all articles' is not working #58

jenniferlin15 opened this issue Oct 7, 2014 · 3 comments
Labels

Comments

@jenniferlin15
Copy link

I clicked on the Alzheimer's Association report tile on home page. 26 articles were returned in the search. I clicked on Select All.
A message appears that tells me 25 articles were added and that I can select the remaining 1.
I click to select the remaining articles.
The page takes a few seconds to load and the article is not added. (Screen shot shows the page with the single remaining article which has not been selected.)
When I click on Select All at this point, nothing happens & nothing is processed (page does not reload).

add articles alm reports

@jure
Copy link
Contributor

jure commented Oct 7, 2014

Interesting. Will take a look, thanks for the report.

@jure
Copy link
Contributor

jure commented Oct 7, 2014

Found it:

2014-10-07 21:48:54.104 [FATAL] NoMethodError - undefined method `[]' for #<SearchResult:0x00000003c18880>:
  app/controllers/home_controller.rb:92:in `block in select_all_search_results'
  app/controllers/home_controller.rb:91:in `select_all_search_results'
  actionpack (3.2.19) lib/action_controller/metal/implicit_render.rb:4:in `send_action'
  actionpack (3.2.19) lib/abstract_controller/base.rb:167:in `process_action'
  actionpack (3.2.19) lib/action_controller/metal/rendering.rb:10:in `process_action'
  actionpack (3.2.19) lib/abstract_controller/callbacks.rb:18:in `block in process_action'

I haven't written a test for the "select all" functionality and haven't refactored it yet. Fixing this soon.

@jenniferlin15
Copy link
Author

This issue also appears in the staging environment for ALM 2.1 reports.
It does not affect the current PLOS production environment for ALM Reports (almreports.plos.org).

jure added a commit that referenced this issue Oct 11, 2014
…'start'. Fix Select All for CrossRef too. Fixes #58
@jure jure closed this as completed in a4a9370 Oct 11, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants