-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Font corrections #118
Comments
OK, will change the title italics, not sure what happened there. Looks like the original tagline was in I considered the buttons and fonts/links changes were improvements, honestly. There was no consistency in terms of what a link is and what a button is. Sometimes the link was blue, sometimes it has an underline, sometimes it's black with an underline, sometimes a button was small, sometimes big. To me this looks a lot cleaner, i.e. a link is blue without an underline: Than this: The benefits of consistency are most evident in something like the new search results page: You instinctively know what on the page is clickable, without really thinking about it. I wasn't done with style fixes, that would be part of polishing. I can make it like it was, but I'd at least like some good reasons to do that. If it's only for consistency with PLOS Search, then I would argue that PLOS Search would benefit from these changes too, e.g. like this: When the user sees this page she thinks: I can click on the blue things. Vs. the current: I could imagine the user looking at this page and thinking: there's the title of the paper which is black underline, I guess I can click it, because it's underline. There are some other black things, I guess I can't click those because they don't have an underline. And then there are some blue things, which surely I can click, because they are blue. That's a lot more to process. Again, happy to change back to what it was, but my argument (and my goal when I set out to do these optimizations) is that there is a lot of value in consistency across the app in terms of how complex and straight-forward it feels for the user. And again, I wasn't done with the style optimizations, I merely came to a point where it was good enough to finish facets. |
Oh, I actually agree about the buttons font, it should be fixed. It looks funny now because it's faux-bold, as the FS Albert doesn't load from |
OK, I'll implement the link/article search result color changes in order to keep consistency with PLOS' publishing platform, although I personally still disagree. The "Clear All" button will be fixed, agreed on all points in terms of primary/secondary actions. |
Thanks Jennifer, will fix. |
…t to distinguish from primary buttons, fixes part of #118.
Oh boy, that's a lot of computed CSS. I can't really use it, I need to figure out what exact changes you would like on which element, computed is just everything that the element inherited from all of CSS. For this, I hope you have you taken into account that since your recent fontdeck.com configuration change, the actual FS Albert Web font is not loading in production? If you took current production as a reference point, it is a potentially wrong reference point as all FS Albert Web text will appear in Verdana or Arial. I'll try to make sense of these changes.
^ This one's for you, @mfenner. |
We need to discuss this. The Your List button is wider because we are displaying the name of the logged-in user. "Your List" looks weird on this wide button, therefore I renamed to "Your Article List". There are other ways to add login/logout functionality to the existing layout, but I felt that this is one of the most unobtrusive ways. Rectular vs. curved I have no strong opinion. |
A few corrections for the site:
the title "ALM: Measuring the Impact of Research" should not be italicized
The button font should be corrected back to the original font

Fonts in the Review list of articles page need to be corrected back too

Paper titles, while hyperlinked, should not be in blue. They should be in black font.
Search results page - paper titles font should be fixed back as well as the links on the right hand column.

The text was updated successfully, but these errors were encountered: