Add GitHub build server #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
|
As mentioned in ppy/osu-framework#4514 (comment), I'll need to take a look into this again and probably use the API, since we can only have a limited number of annotations and there's no display other than: |
|
Maybe it's fine to get this in as-is for now? From experience having used my fork with this PR, the output has been adequate. I haven't yet been able to find the time to implement API annotations :( |
|
Sounds good to me, better have something than nothing at all 😄 |
laedit
added a commit
that referenced
this pull request
Oct 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hope this is fine without tests - it's an MVP implementation using console-based annotations.
Seen working here: https://github.com/smoogipoo/osu-framework/pull/28/checks (and check the files listing for annotations).