Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update formidable #1800

Merged
merged 2 commits into from
Apr 23, 2024
Merged

Update formidable #1800

merged 2 commits into from
Apr 23, 2024

Conversation

tomstrong64
Copy link
Contributor

@tomstrong64 tomstrong64 commented Apr 23, 2024

This pull request updates the formidable dependency which patches CVE-2022-29622.
Closes #1799

formidable v3 handles multipart/form-data slightly differently so changes have been made to transform this data to match the current format.

Checklist

  • I have ensured my pull request is not behind the main or master branch of the original repository.
  • I have rebased all commits where necessary so that reviewing this pull request can be done without having to merge it first.
  • I have written a commit message that passes commitlint linting.
  • I have ensured that my code changes pass linting tests.
  • I have ensured that my code changes pass unit tests.
  • I have described my pull request and the reasons for code changes along with context if necessary.

Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@babel/[email protected] Transitive: environment, eval, filesystem, network, shell +34 1.99 MB nicolo-ribaudo
npm/@babel/[email protected] environment, filesystem, unsafe Transitive: shell +47 10.6 MB nicolo-ribaudo
npm/@babel/[email protected] unsafe Transitive: environment, filesystem, shell +13 5.71 MB nicolo-ribaudo
npm/@babel/[email protected] environment, filesystem Transitive: shell +122 10.3 MB nicolo-ribaudo
npm/@commitlint/[email protected] Transitive: environment, eval, filesystem, shell, unsafe +145 44.6 MB escapedcat
npm/@commitlint/[email protected] Transitive: filesystem +5 44.9 kB escapedcat
npm/[email protected] None 0 13.2 kB loganfsmyth
npm/[email protected] None 0 0 B
npm/[email protected] network 0 6.1 kB jongleberry
npm/[email protected] network Transitive: environment, eval, filesystem, unsafe +24 1.07 MB dougwilson
npm/[email protected] filesystem, network, unsafe Transitive: environment, eval +119 4.83 MB goto-bus-stop
npm/[email protected] None +2 34.1 kB dougwilson
npm/[email protected] None 0 15.6 kB titanism
npm/[email protected] filesystem Transitive: environment, eval, shell +17 35.5 MB amilajack
npm/[email protected] environment, filesystem Transitive: eval, shell, unsafe +78 10.4 MB eslintbot
npm/[email protected] environment Transitive: eval +7 199 kB dougwilson
npm/[email protected] environment, filesystem, network Transitive: eval, unsafe +41 1.37 MB wesleytodd
npm/[email protected] filesystem Transitive: environment +14 1.29 MB henrikjoreteg
npm/[email protected] None +5 217 kB grossacasacs
npm/[email protected] network 0 4.5 kB sindresorhus
npm/[email protected] filesystem, shell 0 6.06 kB typicode
npm/[email protected] Transitive: environment, filesystem, shell +54 6.4 MB okonet
npm/[email protected] environment, filesystem Transitive: eval, shell +75 5.2 MB juergba
npm/[email protected] filesystem Transitive: environment +16 665 kB linusu
npm/[email protected] environment, filesystem, unsafe Transitive: shell +64 2.94 MB coreyfarrell
npm/[email protected] None 0 18.3 kB wooorm
npm/[email protected] None 0 9.89 kB titanism
npm/[email protected] network +1 20.7 kB btd
npm/[email protected] eval 0 408 kB btd
npm/[email protected] environment +7 309 kB goto-bus-stop
npm/[email protected] environment, filesystem Transitive: unsafe +73 42.6 MB sindresorhus
npm/[email protected] environment, filesystem, network, shell +3 2.06 MB vvo

🚮 Removed packages: npm/[email protected]

View full report↗︎

Copy link

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSource
Potential typo squat npm/[email protected]

View full report↗︎

Next steps

What is a typosquat?

Package name is similar to other popular packages and may not be the package you want.

Use care when consuming similarly named packages and ensure that you did not intend to consume a different package. Malicious packages often publish using similar names as existing popular packages.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

@erwanriou
Copy link

hello @jimmywarting it would amazing if you could take a look at it. despite been in devDependencies it seems this is blocking some few CI/CD that are not very vulnerability-friendly :)

@carlosparreno
Copy link

Same as @erwanriou, this is blocking our CI/CD pipelines since today. npm audit would report this as a Critical Vulnerability.

I would appreciate if this can be reviewed and merge.

Thanks in advance!

@titanism titanism marked this pull request as ready for review April 23, 2024 16:50
@titanism
Copy link
Collaborator

Thank you, seems OK. Will release most likely as a minor version bump once tests finish.

@andrew-scott-fischer
Copy link

andrew-scott-fischer commented Apr 23, 2024

Error: Cannot find module 'node:fs'

@tomstrong64 I don't think that import is portable for old versions of NodeJS.
Looking through the docs, I think that notation was added in Node16.

@titanism titanism merged commit 03de30c into ladjs:master Apr 23, 2024
0 of 5 checks passed
@titanism
Copy link
Collaborator

Ref: node-formidable/formidable#976

titanism added a commit that referenced this pull request Apr 23, 2024
@titanism
Copy link
Collaborator

Hi folks, team here from @forwardemail - we're helping update this now, had to fix some CI issues.

Please support our efforts and helping to maintain npm packages like formidable by signing up at https://forwardemail.net

@titanism
Copy link
Collaborator

All tests seem to pass, we are doing a major version bump and dropping support for < 14.18.0

@titanism
Copy link
Collaborator

🚀 v9.0.0 released to npm 🚀

https://github.com/ladjs/superagent/releases/tag/v9.0.0

thank you @tomstrong64 🙏

Forward Email
https://forwardemail.net

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Formidable <3.2.4 Arbitrary File Upload Critical Severity
5 participants