Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
sink: bugfix sequence number wrapping for EOS
KIP-98 specifies that a sequence number will "wrap" on overflow. There is no description of what wrapping is, so the obvious implementation is just to wrap negative. While browsing the Kafka source, I noticed that they actually just wrap back to 0. So, I tested producing >2**31 records, and the first batch after wrapping causes INVALID_RECORD problems. I then changed to this logic (mirroring Kafka's) and producing >2**31 records is fine.
- Loading branch information