Require bzip2 on *nix #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…inker errors when building. This is due to bzip2 being compiled from source for WIN32 only.
|
CMake output with this commit:
If bzip2-devel is missing:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you run CMake and then build on *nix without having bzip2-devel installed, build will fail with linker error for -lbz2. This is due to the fact that ZLIB_BZIP2_FILES is added to compile target for WIN32 only. So, bzip2 is compiled from source on Windows but not for *nix. This change fails the CMake build if bzip2 is missing.