-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(RAIN-94335): Adding permission for terraform version 0.19.0 #128
Conversation
memoryDB qbusiness resourcegroups servicecatalogappregistry oam clouddirectory optimizationhub budgets billingconsole
@@ -241,6 +241,30 @@ data "aws_iam_policy_document" "lacework_audit_policy" { | |||
] | |||
resources = ["*"] | |||
} | |||
|
|||
statement { | |||
sid = "KINESISVIDEO" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: It will be good to sort the API's so its easy cross reference it with the helm config for permission.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Applicable for all the services added / modified.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All these APIs are actually sorted, just in the way that AWS returns. No idea what order they are in, but they should be in the same order as read-me is.
|
||
statement { | ||
sid = "AMP" | ||
actions = ["aps:ListScrapers", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: It will be good to sort the API's so its easy cross reference it with the helm config for permission.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All these APIs are actually sorted, just in the way that AWS returns. No idea what order they are in, but they should be in the same order as read-me is.
"kinesisvideo:GetDataEndpoint", | ||
"kinesisvideo:DescribeImageGenerationConfiguration", | ||
sid = "MEMORYDB" | ||
actions = ["memorydb:DescribeMultiRegionClusters", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: It will be good to sort the API's so its easy cross reference it with the helm config for permission.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All these APIs are actually sorted, just in the way that AWS returns. No idea what order they are in, but they should be in the same order as read-me is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since it is not encouraged to use List*, describe*, etc.. we need to list each individual API as in this PR. Look good to me
Summary
Adding readonly permissions for services:
memoryDB
qbusiness
qconnect
qapps
resourcegroups
servicecatalogappregistry
oam
clouddirectory
optimizationhub
budgets
billingconsole
How did you test this change?
Applied to dev aws account and tested the permission in the iam policy simulator

Issue
https://lacework.atlassian.net/browse/RAIN-94335