Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pull_chunk size overflow error #61

Merged
merged 1 commit into from
Feb 13, 2023

Conversation

florin-pop
Copy link
Contributor

An overflow might happen when the value of max_samples is too big causing liblsl to raise an exception when checking if it is a multiple of n_channels.

In our case max_samples was 2280000000 which was passed as a negative value to the lib.

This PR fixes the problem by casting it to the correct type: size_t.

---------

Co-authored-by: Newton Sander <[email protected]>
@cboulay cboulay merged commit 28a5e5f into labstreaminglayer:master Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants