casbin: add EnforceHandler to allow custom callback to handle enforcing. #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #66 +/- ##
==========================================
+ Coverage 55.41% 56.76% +1.35%
==========================================
Files 8 8
Lines 462 643 +181
==========================================
+ Hits 256 365 +109
- Misses 186 256 +70
- Partials 20 22 +2
Continue to review full report at Codecov.
|
aldas
force-pushed
the
casbin_custom_enforcehandler
branch
from
819f0ac to
d222dcd
Compare
|
@lammel could you review |
This was referenced Dec 7, 2021
suzaku
reviewed
Dec 7, 2021
| return config.ErrorHandler(c, err, http.StatusInternalServerError) | ||
| } | ||
| if !pass { | ||
| return config.ErrorHandler(c, errors.New("enforce did not pass"), http.StatusForbidden) |
There was a problem hiding this comment.
Can you make the status code configurable? For example, one might use 402 instead of 403.
There was a problem hiding this comment.
this can be done inside/with errorhandler.
|
@lammel ping |
lammel
approved these changes
Dec 15, 2021
|
LGTM :) |
|
Should be ok now. Tagged a new release - 0.12.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
casbin:
CI:
honnef.co/go/tools/cmd/staticcheckin CI flow causes dependency problems with older Go versions with we also support.This should be enought to handle cases for: #58, #61 and #65