-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding zipkin open tracing #48
Conversation
Codecov Report
@@ Coverage Diff @@
## master #48 +/- ##
==========================================
+ Coverage 50.00% 54.10% +4.10%
==========================================
Files 5 8 +3
Lines 326 438 +112
==========================================
+ Hits 163 237 +74
- Misses 153 182 +29
- Partials 10 19 +9
Continue to review full report at Codecov.
|
@carlosedp - I fixed the failing test, appreciate if you can review it? |
@jcchavezs - Thanks for reviewing. If you think I resolved all the open comments, can you please approve? |
Just a very minor nit. No need to call it Otherwise, truly great work! |
@aldas - can you please review, I think I resolved most of your comments & thanks for such a detailed explanation. |
@jcchavezs - I want to leave it as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
LGTM! Great work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only have one request. Please split up the PR into the zipkin tracing related files (with this PR) and the project related changes (like ISSUE_TEMPLATE, stale bot), ... into another PR.
So only the README.md and zipkin* files should be merged with this PR.
As aldas approved already we are basically ready to merge after splitting.
@lammel - Okay, force pushed just zipkin tracing changes. I'm going to send 2 additional PRs |
Great, thanks a lot @arun0009! |
@arun0009 do you mind adding this extension into this list? https://github.com/openzipkin/openzipkin.github.io/blob/master/_data/community_tracers_instrumentation.yml. Later this will show up in https://zipkin.io/pages/tracers_instrumentation.html |
done @jcchavezs |
This PR should resolve #46
Adding Zipkin Middleware Functions (Server, Proxy) and util functions for Tracing.
Updating go versions, workflows etc.
@jcchavezs Would appreciate it if you can review this PR.
@carlosedp - Prometheus Metrics Test is failing? I upgraded all library versions and go version to 1.16 of echo-contrib in this PR (but when I reverted back to master version of go.mod prometheus test was still failing, last test).