Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow dump request/response body to opentracing's tags #38

Merged
merged 3 commits into from
Nov 5, 2020

Conversation

phanletrunghieu
Copy link
Contributor

I added IsBodyDump to TraceConfig. If it equal true, tracing info will have request & response's body like this image.

image

@codecov
Copy link

codecov bot commented Aug 17, 2020

Codecov Report

Merging #38 into master will increase coverage by 1.68%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #38      +/-   ##
==========================================
+ Coverage   49.41%   51.09%   +1.68%     
==========================================
  Files           4        5       +1     
  Lines         344      364      +20     
==========================================
+ Hits          170      186      +16     
- Misses        164      168       +4     
  Partials       10       10              
Impacted Files Coverage Δ
jaegertracing/body_dump_response_writer.go 50.00% <50.00%> (ø)
jaegertracing/jaegertracing.go 40.33% <100.00%> (+6.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d6967a...5805d19. Read the comment docs.

@lammel
Copy link
Contributor

lammel commented Nov 5, 2020

Looking good. As it is configurable and off by default no body data (like passwords) is leaked unexpectedly.
Thanks for your contribution @phanletrunghieu

@lammel lammel merged commit 978e622 into labstack:master Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants