Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use common/expfmt instead of local http fetch for PushGateway #29

Merged
merged 2 commits into from
Nov 22, 2020
Merged

use common/expfmt instead of local http fetch for PushGateway #29

merged 2 commits into from
Nov 22, 2020

Conversation

Pirionfr
Copy link

implement fetch metrics using prometheus common/expfmt instead of local http Get

@codecov
Copy link

codecov bot commented Feb 12, 2020

Codecov Report

Merging #29 into master will increase coverage by 1.16%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #29      +/-   ##
==========================================
+ Coverage   50.00%   51.16%   +1.16%     
==========================================
  Files           5        4       -1     
  Lines         326      342      +16     
==========================================
+ Hits          163      175      +12     
- Misses        153      157       +4     
  Partials       10       10              
Impacted Files Coverage Δ
prometheus/prometheus.go 52.38% <83.33%> (+4.42%) ⬆️
jaegertracing/jaegertracing.go 33.64% <0.00%> (-7.43%) ⬇️
jaegertracing/body_dump_response_writer.go
session/session.go 90.90% <0.00%> (+1.43%) ⬆️
casbin/casbin.go 83.33% <0.00%> (+3.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 978e622...21757f5. Read the comment docs.

@Pirionfr Pirionfr requested a review from vishr February 16, 2020 09:23
Copy link
Contributor

@lammel lammel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Could you rebase this PR on master for merging please.

@Pirionfr Pirionfr requested a review from lammel November 6, 2020 14:41
@lammel
Copy link
Contributor

lammel commented Nov 22, 2020

Thanks for your contribution @Pirionfr .

@lammel lammel merged commit b01f7f1 into labstack:master Nov 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants