Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prometheus invalidutf8 #124

Merged
merged 2 commits into from
Dec 23, 2024
Merged

Prometheus invalidutf8 #124

merged 2 commits into from
Dec 23, 2024

Conversation

aldas
Copy link
Contributor

@aldas aldas commented Dec 23, 2024

relates to #122 and #117

Copy link

codecov bot commented Dec 23, 2024

Codecov Report

Attention: Patch coverage is 42.85714% with 12 lines in your changes missing coverage. Please review.

Project coverage is 63.51%. Comparing base (e3d5d99) to head (67d74d4).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
echoprometheus/prometheus.go 42.85% 8 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #124      +/-   ##
==========================================
- Coverage   64.08%   63.51%   -0.58%     
==========================================
  Files           9        9              
  Lines         944      962      +18     
==========================================
+ Hits          605      611       +6     
- Misses        300      308       +8     
- Partials       39       43       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aldas aldas merged commit 84826fa into labstack:master Dec 23, 2024
11 of 12 checks passed
@aldas aldas deleted the prometheus_invalidutf8 branch December 23, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant