Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make splash screen widget compatible with PySide6 #111

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

chrisjbillington
Copy link
Member

Unsure about the status of the other widgets in labscript-utils, figure I'll address them when testing the other applications with PySide6. The need to modify the splash screen became apparent when adding PySide6 compatibility for runmanager (labscript-suite/runmanager#118).

This now works with either PyQt5 or PySide6, and is a bit of an improvement regardless - it follows more closely what Qt's build-in spash screen widget does.

@chrisjbillington
Copy link
Member Author

chrisjbillington commented Dec 17, 2024

FWIW I don't have a general plan to port everything to PySide6 imminently, rather I'm porting an unrelated application and was using runmanager as a bit of a testbed. But qtutils 4.0 supports PySide6 now so porting labscript suite applications is now possible.

With PySide6 being a sensibly-behaving library (compared to PySide2 which had some major deficiencies) and the licensing situation favouring it over PyQt, it doesn't seem like we should go out of our way to support PyQt6 without good reason. Anaconda is still PyQt5-only, and who knows what they'll do - whether they'll include PySide6 or PyQt6 when they drop PyQt5. Maybe conda (or at least Anaconda and their main channel) will cease to be relevant by then and make our lives easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant