Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update terminal ingress #4448

Closed
wants to merge 11 commits into from
Closed

Conversation

wallyxjh
Copy link
Contributor

No description provided.

@sealos-ci-robot
Copy link
Member

sealos-ci-robot commented Dec 26, 2023

🤖 Generated by lychee action

Summary

Status Count
🔍 Total 1147
✅ Successful 379
⏳ Timeouts 0
🔀 Redirected 0
👻 Excluded 767
❓ Unknown 0
🚫 Errors 0

Full action output

Full Github Actions output

Copy link

sweep-ai bot commented Dec 26, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

Copy link

codecov bot commented Dec 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.45%. Comparing base (d73becb) to head (5c57346).
Report is 59 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4448   +/-   ##
=======================================
  Coverage   65.45%   65.45%           
=======================================
  Files           8        8           
  Lines         660      660           
=======================================
  Hits          432      432           
  Misses        180      180           
  Partials       48       48           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -21,8 +21,11 @@ import (

networkingv1 "k8s.io/api/networking/v1"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/utils/pointer"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pointer is deprecated and why import to same package?

Copy link

stale bot commented Feb 27, 2024

This issue has been automatically closed because we haven't heard back for more than 60 days, please reopen this issue if necessary.

@stale stale bot closed this Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants