Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix golang ci lint version #4154

Merged
merged 1 commit into from
Oct 24, 2023
Merged

fix golang ci lint version #4154

merged 1 commit into from
Oct 24, 2023

Conversation

bxy4543
Copy link
Member

@bxy4543 bxy4543 commented Oct 24, 2023 •
edited by ghost
Loading

🤖 Generated by Copilot at 595054b

Summary

🔧🚨🔁

Fixed the version of golangci-lint-action to 1.54.2 in all GitHub workflows. This ensures consistent and reliable linting and testing of the code.

golangci-lint-action
fixed to a stable version
autumn of workflows

Walkthrough

  • Fix the version of golangci-lint-action to 1.54.2 in all workflows to avoid potential breaking changes or bugs (link, link, link)

@bxy4543 bxy4543 requested a review from zzjin October 24, 2023 02:23
@sealos-ci-robot
Copy link
Member

🤖 Generated by lychee action

Summary

Status Count
🔍 Total 956
✅ Successful 375
⏳ Timeouts 0
🔀 Redirected 0
👻 Excluded 580
❓ Unknown 0
🚫 Errors 0

Full action output

Full Github Actions output

@lingdie lingdie merged commit a4adbb7 into labring:main Oct 24, 2023
46 of 47 checks passed
@sweep-ai
Copy link

sweep-ai bot commented Oct 24, 2023

Apply Sweep Rules to your PR?

  • Apply: Leftover TODOs in the code should be handled.
  • Apply: All new business logic should have corresponding unit tests in the tests/ directory.
  • Apply: Any clearly inefficient or repeated code should be optimized or refactored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lingdie lingdie lingdie approved these changes

@zzjin zzjin Awaiting requested review from zzjin

Assignees
No one assigned
Labels
area/workflow size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bxy4543 @sealos-ci-robot @lingdie