Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Automated CherryPick Update for release-v4.4 #4109

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

sealos-ci-robot
Copy link
Member

@sealos-ci-robot sealos-ci-robot commented Oct 17, 2023

🤖 Generated by Copilot at 655e558

Summary

🔄🚀🧹

Improved the performance and readability of the registry sync feature by using concurrency and removing unnecessary code. Changed the signature of sync mode functions in pkg/filesystem/registry/sync.go.

Sing, O Muse, of the swift and skillful coder
Who refactored the registry sync logic with great art
And launched a thousand goroutines and channels in order
To speed up the process and simplify the part

Walkthrough

  • Add constants for sync modes and refactor sync logic to use concurrent goroutines and channels (link,link)
  • Simplify syncViaSSH and syncViaHTTP functions and remove unused loginRegistry function (link)
  • Modify error handling of s.execer.CmdAsyncWithContext to ignore context canceled error (link)
  • Remove unused imports from registry package (link)

Automated changes by create-pull-request GitHub action

@sweep-ai
Copy link

sweep-ai bot commented Oct 17, 2023

Apply Sweep Rules to your PR?

  • Apply: Leftover TODOs in the code should be handled.
  • Apply: All new business logic should have corresponding unit tests in the tests/ directory.
  • Apply: Any clearly inefficient or repeated code should be optimized or refactored.

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

All modified lines are covered by tests ✅

📢 Thoughts on this report? Let us know!.

@cuisongliu cuisongliu merged commit c8f7a9c into release-v4.4 Oct 17, 2023
125 of 126 checks passed
@cuisongliu cuisongliu deleted the cherry-pick-release-v4.4-4106 branch October 17, 2023 14:42
@sealos-ci-robot
Copy link
Member Author

/cherry-pick release-v4.3

@sealos-ci-robot
Copy link
Member Author

🤖 says: Error cherry-picking.

Auto-merging pkg/filesystem/registry/sync.go
CONFLICT (content): Merge conflict in pkg/filesystem/registry/sync.go
error: could not apply c8f7a9c... fix: sync registry contents via ssh (#4106) (#4109)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

@sealos-ci-robot
Copy link
Member Author

🤖 says: ‼️ cherry pick action failed.
See: https://github.com/labring/sealos/actions/runs/6572582509

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants