fix: make the usage of '--env' flag more precisely #4060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sealos-ci-robot
added
area/apply
🤖 Generated by lychee actionSummary
Full action output |
|
fix #4058 |
Codecov ReportAttention:
📢 Thoughts on this report? Let us know!. |
fengxsong
force-pushed
the
env_arguments
branch
from
5b96fb6 to
5e8b173
Compare
cuisongliu
reviewed
Oct 10, 2023
cmd/sealos/cmd/gen.go
Outdated
| @@ -23,6 +23,7 @@ import ( | |||
|
|
|||
| "github.com/spf13/cobra" | |||
|
|
|||
| "github.com/labring/sealos/controllers/pkg/utils/logger" | |||
There was a problem hiding this comment.
logger using pkg/logger
Signed-off-by: fengxsong <[email protected]>
fengxsong
force-pushed
the
env_arguments
branch
from
5e8b173 to
b2270eb
Compare
cuisongliu
approved these changes
Oct 10, 2023
|
/cherry-pick release-v4.4 |
|
🤖 says: cherry pick action finished successfully 🎉! |
sealos-ci-robot
pushed a commit
that referenced
this pull request
Oct 10, 2023
Signed-off-by: fengxsong <[email protected]>
cuisongliu
pushed a commit
that referenced
this pull request
Oct 10, 2023
Signed-off-by: fengxsong <[email protected]> Co-authored-by: fengxsong <[email protected]>
This was referenced Oct 10, 2023
muicoder
added a commit
to muicoder/sealos
that referenced
this pull request
Oct 11, 2023
fix: make the usage of '--env' flag more precisely (labring#4060) (labring#4063)
Merged
cuisongliu
pushed a commit
that referenced
this pull request
Oct 11, 2023
bxy4543
pushed a commit
to bxy4543/sealos
that referenced
this pull request
Oct 13, 2023
Signed-off-by: fengxsong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Generated by Copilot at 5b96fb6
Summary
🌟📝🧹
This pull request improves the sealos gen command and the clusterfile package by using consistent logging, simplifying the code, and clarifying the flags. It also fixes a bug in the gen command related to default values for kubeadm configs.
Walkthrough
ClusterFiletype andLoadKubeadmConfigsfunction, as it is no longer needed (link, link, link)