fix(BA-880): Aggregate multi-kernel session utilization in idle checker #3861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
size:S
HyeockJinKim
reviewed
Mar 1, 2025
src/ai/backend/manager/idle.py
Outdated
Comment on lines
1235
to
1237
| divider = kernel_counter or 1 | ||
| total_utilizations = {k: v / divider for k, v in utilizations.items()} | ||
| return total_utilizations if total_utilizations else None |
There was a problem hiding this comment.
It seems better to first return None by checking if kernel_counter is 0.
HyeockJinKim
approved these changes
Mar 1, 2025
lablup-octodog
pushed a commit
that referenced
this pull request
Mar 1, 2025
…er (#3861) Co-authored-by: HyeockJinKim <[email protected]> Backported-from: main (25.3) Backported-to: 24.09 Backport-of: 3861
lablup-octodog
pushed a commit
that referenced
this pull request
Mar 1, 2025
…er (#3861) Co-authored-by: HyeockJinKim <[email protected]> Backported-from: main (25.3) Backported-to: 24.03 Backport-of: 3861
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 1, 2025
…er (#3861) (#3866) Co-authored-by: Sanghun Lee <[email protected]> Co-authored-by: HyeockJinKim <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 1, 2025
…er (#3861) (#3865) Co-authored-by: Sanghun Lee <[email protected]> Co-authored-by: HyeockJinKim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #3857 (BA-880)
Checklist: (if applicable)