Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(BA-595): Add row_id field to UserNode GQL schema #3525

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

agatha197
Copy link
Contributor

@agatha197 agatha197 commented Jan 22, 2025

resolves #3524 (BA-595)

Adds a row_id field to the UserNode GraphQL schema, enabling direct querying and mutation of users by their database ID. This field represents the undecoded UUID value stored in the database and was introduced in version 25.2.0.

The change updates the query filter and order specifications to use row_id instead of uuid for consistency with the new field naming.

Checklist:

  • Milestone metadata specifying the target backport version
  • Mention to the original issue

📚 Documentation preview 📚: https://sorna--3525.org.readthedocs.build/en/3525/


📚 Documentation preview 📚: https://sorna-ko--3525.org.readthedocs.build/ko/3525/


📚 Documentation preview 📚: https://sorna--3525.org.readthedocs.build/en/3525/


📚 Documentation preview 📚: https://sorna-ko--3525.org.readthedocs.build/ko/3525/

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added comp:manager Related to Manager component size:XS ~10 LoC labels Jan 22, 2025
@agatha197 agatha197 force-pushed the feature/add-row_id-to-usernode branch from 8913843 to 55c8158 Compare January 22, 2025 10:38
@github-actions github-actions bot added area:docs Documentations size:S 10~30 LoC and removed size:XS ~10 LoC labels Jan 22, 2025
@agatha197 agatha197 force-pushed the feature/add-row_id-to-usernode branch from eaf7027 to fcc8745 Compare January 23, 2025 07:05
@agatha197 agatha197 requested a review from fregataa January 23, 2025 07:07
@fregataa
Copy link
Member

Please complete the checklist and remove placeholders among them

@agatha197 agatha197 added this to the 25Q1 milestone Jan 23, 2025
@agatha197 agatha197 force-pushed the feature/add-row_id-to-usernode branch from 7384afb to 2d43fe8 Compare February 4, 2025 02:27
Comment on lines +707 to +708
"""Added in 25.2.0. The undecoded id value stored in DB."""
row_id: UUID
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don’t think exposing the DB row ID to external is a good API design.

@jopemachine
Copy link
Member

PR description appears to be referring to itself.

resolves #3525
-> resolves #3524

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:docs Documentations comp:manager Related to Manager component size:S 10~30 LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a row_id field to UserNode GQL schema
4 participants