-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(BA-595): Add row_id
field to UserNode GQL schema
#3525
Open
agatha197
wants to merge
3
commits into
main
Choose a base branch
from
feature/add-row_id-to-usernode
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+8
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8913843
to
55c8158
Compare
fregataa
requested changes
Jan 23, 2025
eaf7027
to
fcc8745
Compare
Please complete the checklist and remove placeholders among them |
Co-authored-by: octodog <[email protected]>
Co-authored-by: octodog <[email protected]>
7384afb
to
2d43fe8
Compare
HyeockJinKim
reviewed
Feb 6, 2025
Comment on lines
+707
to
+708
"""Added in 25.2.0. The undecoded id value stored in DB.""" | ||
row_id: UUID |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don’t think exposing the DB row ID to external is a good API design.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #3524 (BA-595)
Adds a
row_id
field to theUserNode
GraphQL schema, enabling direct querying and mutation of users by their database ID. This field represents the undecoded UUID value stored in the database and was introduced in version 25.2.0.The change updates the query filter and order specifications to use
row_id
instead ofuuid
for consistency with the new field naming.Checklist:
📚 Documentation preview 📚: https://sorna--3525.org.readthedocs.build/en/3525/
📚 Documentation preview 📚: https://sorna-ko--3525.org.readthedocs.build/ko/3525/
📚 Documentation preview 📚: https://sorna--3525.org.readthedocs.build/en/3525/
📚 Documentation preview 📚: https://sorna-ko--3525.org.readthedocs.build/ko/3525/