Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add prometheus client #3184

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

HyeockJinKim
Copy link

@HyeockJinKim HyeockJinKim commented Dec 2, 2024

I added prometheus metrics for api & events.
It seems that metrics for Kernel, Agent, Session, etc. should be collected in Agent, not in Manager.
(It is difficult to collect metrics with the event structure).

Since the event dispatcher exists in common, the event dispatcher only specifies the required Protocol.
When using the event dispatcher in managers and agents, it is intended to work by passing the appropriate metric class.

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version
  • Mention to the original issue
  • Installer updates including:
    • Fixtures for db schema changes
    • New mandatory config options
  • Update of end-to-end CLI integration tests in ai.backend.test
  • API server-client counterparts (e.g., manager API -> client SDK)
  • Test case(s) to:
    • Demonstrate the difference of before/after
    • Demonstrate the flow of abstract/conceptual models with a concrete implementation
  • Documentation
    • Contents in the docs directory
    • docstrings in public interfaces and type annotations

📚 Documentation preview 📚: https://sorna--3184.org.readthedocs.build/en/3184/


📚 Documentation preview 📚: https://sorna-ko--3184.org.readthedocs.build/ko/3184/

@HyeockJinKim HyeockJinKim self-assigned this Dec 2, 2024
@github-actions github-actions bot added area:docs Documentations comp:manager Related to Manager component comp:common Related to Common component size:L 100~500 LoC labels Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:docs Documentations comp:common Related to Common component comp:manager Related to Manager component size:L 100~500 LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant