Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Regression of AgentSummary GQL resolver #3045

Merged
merged 8 commits into from
Nov 28, 2024
Merged

fix: Regression of AgentSummary GQL resolver #3045

merged 8 commits into from
Nov 28, 2024
+9 −7

Conversation

jopemachine
Copy link
Member

@jopemachine jopemachine commented Nov 7, 2024 •
edited by github-actions bot
Loading

When using the AgentSummary GQL query in the main branch, the following error occurs.

{
  "data": {
    "agent_summary": null
  },
  "errors": [
    {
      "message": "Agent.batch_load() got an unexpected keyword argument 'scaling_group'",
      "locations": [
        {
          "line": 2,
          "column": 5
        }
      ],
      "path": [
        "agent_summary"
      ]
    }
  ]
}

This PR fixes the above error and additionally resolves several type errors.

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version

📚 Documentation preview 📚: https://sorna--3045.org.readthedocs.build/en/3045/

📚 Documentation preview 📚: https://sorna-ko--3045.org.readthedocs.build/ko/3045/

@jopemachine jopemachine self-assigned this Nov 7, 2024
@github-actions github-actions bot added area:docs Documentations comp:manager Related to Manager component size:S 10~30 LoC labels Nov 7, 2024
@jopemachine jopemachine added the type:bug Reports about that are not working label Nov 7, 2024
@jopemachine jopemachine added this to the 23.09 milestone Nov 7, 2024
@jopemachine jopemachine requested a review from fregataa November 7, 2024 07:27
@jopemachine jopemachine marked this pull request as ready for review November 7, 2024 07:27
@jopemachine jopemachine requested a review from fregataa November 8, 2024 05:34
achimnol
achimnol requested changes Nov 12, 2024
View reviewed changes
@jopemachine jopemachine changed the title fix: Wrong AgentSummary GQL implementation fix: Regression of the AgentSummary GQL resolver Nov 12, 2024
@jopemachine jopemachine requested a review from achimnol November 12, 2024 01:34
@jopemachine jopemachine changed the title fix: Regression of the AgentSummary GQL resolver fix: Regression of AgentSummary GQL resolver Nov 12, 2024
@jopemachine jopemachine force-pushed the fix/agent-summary-query branch from ba5ab31 to 2f0546d Compare November 13, 2024 06:44
@jopemachine jopemachine requested a review from fregataa November 13, 2024 06:46
@jopemachine jopemachine force-pushed the fix/agent-summary-query branch from 2f0546d to 44664b6 Compare November 14, 2024 06:57
HyeockJinKim
HyeockJinKim approved these changes Nov 20, 2024
View reviewed changes
Copy link
Collaborator

@HyeockJinKim HyeockJinKim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like there's no problem now.

@HyeockJinKim
Copy link
Collaborator

Ah, ci failed. Could you please check it? @jopemachine

@jopemachine jopemachine force-pushed the fix/agent-summary-query branch from 44664b6 to afcea00 Compare November 20, 2024 00:29
@kyujin-cho kyujin-cho enabled auto-merge November 28, 2024 11:05
@kyujin-cho kyujin-cho added this pull request to the merge queue Nov 28, 2024
Merged via the queue into main with commit 088344a Nov 28, 2024
23 checks passed
@kyujin-cho kyujin-cho deleted the fix/agent-summary-query branch November 28, 2024 11:10
@github-actions GitHub Actions
Copy link

Backport to 23.09 is failed. Please backport manually.

@github-actions GitHub Actions
Copy link

Backport to 24.09 is failed. Please backport manually.

@github-actions GitHub Actions
Copy link

Backport to 24.03 is failed. Please backport manually.

jopemachine added a commit that referenced this pull request Nov 28, 2024
@jopemachine
fix: Regression of AgentSummary GQL resolver (#3045)
0feebd3 
Backported-from: main
Backported-to: 23.09
Backported-of: 3045
jopemachine added a commit that referenced this pull request Nov 28, 2024
@jopemachine
fix: Regression of AgentSummary GQL resolver (#3045)
59fe266
jopemachine added a commit that referenced this pull request Nov 28, 2024
@jopemachine
fix: Regression of AgentSummary GQL resolver (#3045)
d13f6df 
Backported-from: main
Backported-to: 24.03
Backported-of: 3045
jopemachine added a commit that referenced this pull request Nov 28, 2024
@jopemachine
fix: Regression of AgentSummary GQL resolver (#3045)
66b0a99 
Backported-from: main
Backported-to: 23.09
Backported-of: 3045
jopemachine added a commit that referenced this pull request Nov 28, 2024
@jopemachine
fix: Regression of AgentSummary GQL resolver (#3045)
09db69f 
Backported-from: main
Backported-to: 24.09
Backported-of: 3045
github-merge-queue bot pushed a commit that referenced this pull request Nov 28, 2024
@jopemachine
fix: Regression of AgentSummary GQL resolver (#3045) (#3170)
4cbdc0f
github-merge-queue bot pushed a commit that referenced this pull request Nov 28, 2024
@jopemachine
fix: Regression of AgentSummary GQL resolver (#3045) (#3172)
101f0c5
github-merge-queue bot pushed a commit that referenced this pull request Nov 28, 2024
@jopemachine
fix: Regression of AgentSummary GQL resolver (#3045) (#3171)
cf661b0
Yaminyam pushed a commit that referenced this pull request Feb 12, 2025
@jopemachine @Yaminyam
fix: Regression of AgentSummary GQL resolver (#3045)
404273b
Yaminyam pushed a commit that referenced this pull request Feb 12, 2025
@jopemachine @Yaminyam
fix: Regression of AgentSummary GQL resolver (#3045)
8f4630f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HyeockJinKim HyeockJinKim HyeockJinKim approved these changes

@achimnol achimnol Awaiting requested review from achimnol

@fregataa fregataa Awaiting requested review from fregataa

Assignees

@jopemachine jopemachine

Labels
area:docs Documentations comp:manager Related to Manager component size:S 10~30 LoC type:bug Reports about that are not working
Projects
None yet
Milestone
23.09
Development

Successfully merging this pull request may close these issues.
5 participants
@jopemachine @HyeockJinKim @achimnol @fregataa @kyujin-cho