Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add open_to_public to filter and order of endpoint relay API #2954

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

agatha197
Copy link
Contributor

@agatha197 agatha197 commented Oct 23, 2024

follows #2805
This PR adds open_to_public to filter and order of endpoint relay API.

Checklist:

  • Milestone metadata specifying the target backport version
  • Mention to the original issue
  • Installer updates including:
    • Fixtures for db schema changes
    • New mandatory config options
  • Update of end-to-end CLI integration tests in ai.backend.test
  • API server-client counterparts (e.g., manager API -> client SDK)
  • Test case(s) to:
    • Demonstrate the difference of before/after
    • Demonstrate the flow of abstract/conceptual models with a concrete implementation
  • Documentation
    • Contents in the docs directory
    • docstrings in public interfaces and type annotations

Copy link
Contributor Author

agatha197 commented Oct 23, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added comp:manager Related to Manager component size:XS ~10 LoC labels Oct 23, 2024
@agatha197 agatha197 force-pushed the feat/add-open_to_public-filter-and-order branch from cc75270 to e438a46 Compare October 23, 2024 14:24
@agatha197 agatha197 added this to the 24.09 milestone Oct 23, 2024
@HyeockJinKim
Copy link

If you just add open_to_public to the current behavior, the reading from the parser will be linked, right?
Can you tell me the history of this PR and when it should be applied?

@agatha197
Copy link
Contributor Author

agatha197 commented Oct 30, 2024

If you just add open_to_public to the current behavior, the reading from the parser will be linked, right? Can you tell me the history of this PR and when it should be applied?

https://github.com/lablup/backend.ai-control-panel/pull/888 here is it.

@fregataa fregataa force-pushed the feat/add-open_to_public-filter-and-order branch from e438a46 to 1598d64 Compare October 30, 2024 08:08
Copy link
Member

@fregataa fregataa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HyeockJinKim
Copy link

It's been approved, but when will the work be merged? @fregataa

@kyujin-cho kyujin-cho modified the milestones: 24.09, 24.12 Nov 22, 2024
@kyujin-cho kyujin-cho added this pull request to the merge queue Nov 22, 2024
Merged via the queue into main with commit effb70a Nov 22, 2024
24 checks passed
@kyujin-cho kyujin-cho deleted the feat/add-open_to_public-filter-and-order branch November 22, 2024 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:manager Related to Manager component size:XS ~10 LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants