Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Avoid using OrderedDict in the manager API and client SDK #2842

Merged
merged 5 commits into from
Sep 18, 2024

Conversation

achimnol
Copy link
Member

@achimnol achimnol commented Sep 18, 2024

Through PEP-468, Python has guaranteed the insertion ordering of dict as of Python 3.7, while OrderedDict provides intentional reordering as an additional feature.

See: https://docs.python.org/3/library/collections.html#ordereddict-objects

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version

@achimnol achimnol added this to the 24.03 milestone Sep 18, 2024
@achimnol achimnol added type:refactor Refactor codes or add tests. impact:invisible This change is invisible to users (internal changes). labels Sep 18, 2024
@achimnol achimnol self-assigned this Sep 18, 2024
@achimnol achimnol enabled auto-merge September 18, 2024 15:24
@achimnol achimnol added this pull request to the merge queue Sep 18, 2024
Merged via the queue into main with commit 9130c32 Sep 18, 2024
22 of 24 checks passed
@achimnol achimnol deleted the topic/migrate-ordereddict-to-dict branch September 18, 2024 15:28
lablup-octodog pushed a commit that referenced this pull request Sep 18, 2024
…2842)

Backported-from: main (24.09)
Backported-to: 24.03
Backport-of: 2842
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact:invisible This change is invisible to users (internal changes). type:refactor Refactor codes or add tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant