fix: typo in minilang query field spec and column map #2605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
comp:manager
fregataa
changed the title
fregataa
changed the title
fregataa
changed the title
lablup-octodog
pushed a commit
that referenced
this pull request
Aug 1, 2024
Backported-from: main (24.09) Backported-to: 23.09 Backport-of: 2605
lablup-octodog
pushed a commit
that referenced
this pull request
Aug 1, 2024
Backported-from: main (24.09) Backported-to: 24.03 Backport-of: 2605
This was referenced Aug 1, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 1, 2024
Co-authored-by: Sanghun Lee <[email protected]>
1 task
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 6, 2024
Co-authored-by: Sanghun Lee <[email protected]> Co-authored-by: Kyujin Cho <[email protected]>
6 tasks
agatha197
pushed a commit
to lablup/backend.ai-webui
that referenced
this pull request
Aug 8, 2024
### TL;DR Added support for boolean options in BAIPropertyFilter component.  Related core PR: lablup/backend.ai#2605 ### What changed? 1. `AgentList.tsx`: Added `type` and `options` properties to filter properties. 2. `BAIPropertyFilter.stories.tsx`: Updated story to include boolean type property. 3. `BAIPropertyFilter.tsx`: Major updates to support boolean options including default boolean filter options and enhanced value handling. 4. Updated i18n files for new labels. ### How to test? 1. Go to the AgentList component and verify the filter functionality with boolean options. 2. Check the storybook for BAIPropertyFilter and ensure the new boolean property works as expected. 3. Verify i18n changes reflect correctly in the UI. ### Why make this change? To enhance the filtering capabilities by allowing boolean options, providing more flexibility and utility in data filtering. --- <!-- Please precisely, concisely, and concretely describe what this PR changes, the rationale behind codes, and how it affects the users and other developers. --> **Checklist:** (if applicable) - [ ] Mention to the original issue - [ ] Documentation - [ ] Minium required manager version - [ ] Specific setting for review (eg., KB link, endpoint or how to setup) - [ ] Minimum requirements to check during review - [ ] Test case(s) to demonstrate the difference of before/after
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist: (if applicable)