Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated data "helm_repository" #5

Merged
merged 1 commit into from
Jul 13, 2020
+1 −12
Merged

Remove deprecated data "helm_repository" #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ A terraform module to deploy an Application Load Balancer (ALB) Ingress Controll
| helm\_chart\_name | n/a | `string` | `"aws-alb-ingress-controller"` | no |
| helm\_chart\_version | n/a | `string` | `"0.1.13"` | no |
| helm\_release\_name | n/a | `string` | `"aws-alb-ingress-controller"` | no |
| helm\_repo\_name | n/a | `string` | `"eks-incubator"` | no |
| helm\_repo\_url | n/a | `string` | `"http://storage.googleapis.com/kubernetes-charts-incubator"` | no |
| ingress\_class | n/a | `string` | `"alb-ingress"` | no |
| k8s\_namespace | The k8s namespace in which the alb-ingress service account has been created | `string` | `"alb-ingress"` | no |
Expand Down
8 changes: 1 addition & 7 deletions main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,8 @@
data "helm_repository" "default" {
depends_on = [var.mod_dependency]
name = var.helm_repo_name
url = var.helm_repo_url
}

resource "helm_release" "alb_ingress" {
depends_on = [var.mod_dependency]
count = var.enabled ? 1 : 0
name = var.helm_release_name
repository = data.helm_repository.default.metadata[0].name
repository = var.helm_repo_url
chart = var.helm_chart_name
namespace = var.k8s_namespace
version = var.helm_chart_version
Expand Down
4 changes: 0 additions & 4 deletions variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,6 @@ variable "helm_release_name" {
default = "aws-alb-ingress-controller"
}

variable "helm_repo_name" {
default = "eks-incubator"
}

variable "helm_repo_url" {
default = "http://storage.googleapis.com/kubernetes-charts-incubator"
}
Expand Down