Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve AOS and LOS calculations #18

Open
thomasing opened this issue May 14, 2015 · 1 comment
Open

Improve AOS and LOS calculations #18

thomasing opened this issue May 14, 2015 · 1 comment
Assignees
@bjorgan
Labels
enhancement patch number bump

Comments

@thomasing
Copy link
Contributor

Try using elevation rate from observer_find_orbit() to improve AOS and LOS calculations.
@bjorgan
Copy link
Member

bjorgan commented Mar 22, 2016 •
edited
Loading 


Another note: The restrictions on the AOS time point (|elevation| < 0.3 degrees) means that a satellite that is slightly below the horizon will be detected as a valid pass. The time 13081.824586 for the HINODE-satellite in the testcase data is an example of this. Revert changes done in 
c3a2a91dc0947d5953caffbe39ac0d262c9ba1d6 to re-enable this test, which will fail with the current pass finding functions. We probably want to avoid this for the reimplementation.

bjorgan added a commit that referenced this issue Mar 23, 2017
@bjorgan
Avoid some problems in maxele tests due to numerical inaccuracies in …
103deae 
…aoslos-functions, which we have to take care of for #18 and not right now
@bjorgan bjorgan mentioned this issue Mar 28, 2017
Merged
bjorgan added a commit that referenced this issue Apr 23, 2017
@bjorgan
Avoid some problems in maxele tests due to numerical inaccuracies in …
825ad18 
…aoslos-functions, which we have to take care of for #18 and not right now
bjorgan added a commit that referenced this issue Apr 23, 2017
@bjorgan
Avoid some problems in maxele tests due to numerical inaccuracies in …
994ed2d 
…aoslos-functions, which we have to take care of for #18 and not right now
bjorgan added a commit that referenced this issue Apr 23, 2017
@bjorgan
Avoid some problems in maxele tests due to numerical inaccuracies in …
1bbea94 
…aoslos-functions, which we have to take care of for #18 and not right now
@bjorgan bjorgan self-assigned this Dec 3, 2017
@bjorgan bjorgan mentioned this issue Dec 3, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bjorgan bjorgan

Labels
enhancement patch number bump
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ryeng @bjorgan @thomasing