Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add option to activate native integration with appsflyer #19

Merged
merged 4 commits into from
Apr 21, 2022
Merged

feat: add option to activate native integration with appsflyer #19

merged 4 commits into from
Apr 21, 2022

Conversation

johnsouza-loftbr
Copy link
Contributor

Objective: add a new parameter on SegmentConfig to allow integrating Segment with Appsflyer.

Segment.config(
  options: SegmentConfig(
    writeKey: writeKey,
    trackApplicationLifecycleEvents: true,
    appsflyerIntegrationEnabled: true,
    amplitudeIntegrationEnabled: false,
    debug: kDebugMode,
  ),
);

Visual guide for Reviewers:

  • 🚲 Bikeshedding.
  • ⭐️ great increment!
  • 🌟 awesome increment!
  • ⛔️ won't approve before changing it!
  • 🔥 burn it to the ground (aka old code, please remove it).
  • ✅ LGTM: looks good to me!

danielgomezrico
danielgomezrico reviewed Mar 28, 2022
View reviewed changes
Copy link
Contributor

@danielgomezrico danielgomezrico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening the PR, I have some questions :)

example/pubspec.lock Outdated
@@ -68,7 +68,7 @@ packages:
path: ".."
relative: true
source: path
version: "3.5.0"
version: "3.7.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need this update? it is required for app flyer?

example/lib/generated_plugin_registrant.dart Show resolved Hide resolved
danielgomezrico
danielgomezrico suggested changes Mar 30, 2022
View reviewed changes
Copy link
Contributor

@danielgomezrico danielgomezrico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤓

android/build.gradle Outdated
@@ -36,6 +36,7 @@ android {
dependencies {
implementation 'com.segment.analytics.android:analytics:4.10.0'
implementation 'com.segment.analytics.android.integrations:amplitude:3.0.3'
implementation 'com.appsflyer:segment-android-integration:+'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please declare the version, it is not a good idea to have open versions because this may break in the future because of a release from them

example/lib/generated_plugin_registrant.dart Show resolved Hide resolved
danielgomezrico
danielgomezrico approved these changes Apr 5, 2022
View reviewed changes
Copy link
Contributor

@danielgomezrico danielgomezrico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for this

@danielgomezrico danielgomezrico mentioned this pull request Apr 5, 2022
Open
@danielgomezrico danielgomezrico merged commit 8768596 into la-haus:master Apr 21, 2022
@danielgomezrico danielgomezrico mentioned this pull request Jun 14, 2022
Closed
@danielgomezrico danielgomezrico mentioned this pull request Jun 21, 2022
Closed
@danielgomezrico danielgomezrico mentioned this pull request Jun 29, 2022
Closed
@danielgomezrico danielgomezrico mentioned this pull request Aug 4, 2022
Open
@b099l3 b099l3 mentioned this pull request Aug 11, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielgomezrico danielgomezrico danielgomezrico approved these changes

@Santi92 Santi92 Awaiting requested review from Santi92

@sicodelicos2003 sicodelicos2003 Awaiting requested review from sicodelicos2003

@cdmunoz cdmunoz Awaiting requested review from cdmunoz

@juansoos juansoos Awaiting requested review from juansoos

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnsouza-loftbr @danielgomezrico