Refactored sys package with enhancements and new functionalities. #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
l50-renovate-bot
bot
added
area/github
**Added:** - Added imports for bufio and sync to sys package. - Introduced SignalKill constant for immediate process termination. - Developed Cmd struct with fields for command execution and output handling. - Implemented RmRf function for robust path removal. - Created GetTempPath function for determining OS-specific temp directories. - Established new RunCmd method for executing commands with timeout and output. **Changed:** - Moved Signal constants for improved code organization. - Updated RunCmd to utilize StdoutPipe and StderrPipe for output handling. - Enhanced RunCmd for error handling, including command timeouts. - Revised test cases for RunCommand and RunCommandWithTimeout. - Refactored test suite to accommodate new RunCmd implementation. **Removed:** - Eliminated old test implementations for RunCommand and RunCommandWithTimeout.
**Added:** - Created a new custom pre-commit hook script `prettier.sh` to format JSON, YAML, and YML files using Prettier. **Changed:** - Updated GitHub Actions pre-commit workflow to use `mage runPreCommit` command instead of `pre-commit run --all-files`, enhancing the CI process. - Modified `.pre-commit-config.yaml` to use the custom Prettier hook script for formatting instead of the standard Prettier mirror repository hook. **Removed:** - Removed the Prettier mirror repository hook from `.pre-commit-config.yaml`, replacing it with the custom implementation for better control over formatting. These changes enhance code formatting consistency and improve the automation in CI/CD pipeline through custom scripting and workflow adjustments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added:
Changed:
Removed:
Proposed Changes
Related Issue(s)
Testing
Documentation
Screenshots/GIFs (optional)
Checklist
mage runprecommitlocally and fixed any issues that arose.mage runtestslocally and fixed any issues that arose.