Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Title wrongly rendered from item.timer when item.dangerouslySetInnerHtml is set #52

Closed
lehni opened this issue Sep 15, 2023 · 1 comment · Fixed by #53
Closed

Title wrongly rendered from item.timer when item.dangerouslySetInnerHtml is set #52

lehni opened this issue Sep 15, 2023 · 1 comment · Fixed by #53

Comments

@lehni
Copy link
Contributor

lehni commented Sep 15, 2023

The reason is in this faulty line of code, probably an auto-complete error:

vue3-notification/src/components/Notifications.vue

Line 37 in 649d936

v-html="item.timer"

lehni added a commit to ditojs/vue3-notification that referenced this issue Sep 15, 2023
@lehni
Fix rendering of title when dangerouslySetInnerHtml is set (kyvg#52)
afb31fe
@lehni lehni mentioned this issue Sep 15, 2023
Merged
lehni added a commit to ditojs/dito that referenced this issue Sep 15, 2023
@lehni
Fix notification title rendering
2cefebe 
See kyvg/vue3-notification#52
lehni added a commit to ditojs/dito that referenced this issue Sep 15, 2023
@lehni
Fix notification title rendering
1cf6e40 
See kyvg/vue3-notification#52
@kyvg kyvg closed this as completed in #53 Sep 15, 2023
kyvg pushed a commit that referenced this issue Sep 15, 2023
@lehni
Fix rendering of title when dangerouslySetInnerHtml is set (#52) (#53)
f8789d4
@kyvg
Copy link
Owner

kyvg commented Sep 15, 2023

Hi! Thank you for your pr
I'll release it as soon as possible

lehni added a commit to ditojs/dito that referenced this issue Sep 15, 2023
@lehni
Fix notification title rendering
a0f2920 
See kyvg/vue3-notification#52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix rendering of title when dangerouslySetInnerHtml is set (#52) ditojs/vue3-notification
2 participants
@lehni @kyvg