-
Notifications
You must be signed in to change notification settings - Fork 906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(mutate): minimize unmarshals #10702
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KhaledEmaraDev
requested review from
MarcelMue,
realshuting,
MariamFahmy98,
chipzoller and
eddycharly
as code owners
July 23, 2024 02:24
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10702 +/- ##
==========================================
+ Coverage 11.64% 11.66% +0.01%
==========================================
Files 933 933
Lines 85285 85281 -4
==========================================
+ Hits 9933 9945 +12
+ Misses 74223 74203 -20
- Partials 1129 1133 +4 ☔ View full report in Codecov by Sentry. |
realshuting
requested changes
Jul 26, 2024
Signed-off-by: Khaled Emara <[email protected]>
Signed-off-by: Khaled Emara <[email protected]>
KhaledEmaraDev
force-pushed
the
perf-opt-3
branch
from
August 5, 2024 12:12
f99c558
to
901ef40
Compare
dosubot
bot
added
the
size:M
This PR changes 30-99 lines, ignoring generated files.
label
Aug 5, 2024
Signed-off-by: Khaled Emara <[email protected]>
realshuting
approved these changes
Aug 9, 2024
aerosouund
pushed a commit
to aerosouund/kyverno
that referenced
this pull request
Aug 28, 2024
* feat(mutate): minimize unmarshals Signed-off-by: Khaled Emara <[email protected]> * test(mutate): test type assertion Signed-off-by: Khaled Emara <[email protected]> * chore(codegen): remove unused import Signed-off-by: Khaled Emara <[email protected]> --------- Signed-off-by: Khaled Emara <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Minimize the number of times we have to unmarshal within mutate policies.
Related issue
Milestone of this PR
Documentation (required for features)
My PR contains new or altered behavior to Kyverno.
What type of PR is this
Proposed Changes
Proof Manifests
Checklist
Further Comments