Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mutate): minimize unmarshals #10702

Merged
merged 4 commits into from
Aug 9, 2024
Merged

Conversation

KhaledEmaraDev
Copy link
Contributor

Explanation

Minimize the number of times we have to unmarshal within mutate policies.

Related issue

Milestone of this PR

Documentation (required for features)

My PR contains new or altered behavior to Kyverno.

What type of PR is this

Proposed Changes

Proof Manifests

Checklist

  • I have read the contributing guidelines.
  • I have read the PR documentation guide and followed the process including adding proof manifests to this PR.
  • This is a bug fix and I have added unit tests that prove my fix is effective.
  • This is a feature and I have added CLI tests that are applicable.
  • My PR needs to be cherry picked to a specific release branch which is .
  • My PR contains new or altered behavior to Kyverno and
    • CLI support should be added and my PR doesn't contain that functionality.

Further Comments

Copy link

codecov bot commented Jul 23, 2024

Codecov Report

Attention: Patch coverage is 38.88889% with 11 lines in your changes missing coverage. Please review.

Project coverage is 11.66%. Comparing base (6e73e85) to head (5062610).

Files Patch % Lines
api/kyverno/v1/common_types.go 0.00% 4 Missing ⚠️
pkg/engine/mutate/mutation.go 70.00% 2 Missing and 1 partial ⚠️
api/kyverno/v1/zz_generated.deepcopy.go 0.00% 1 Missing ⚠️
.../applyconfigurations/kyverno/v1/foreachmutation.go 0.00% 1 Missing ⚠️
pkg/engine/handlers/mutation/common.go 0.00% 1 Missing ⚠️
pkg/policy/mutate/validate.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10702      +/-   ##
==========================================
+ Coverage   11.64%   11.66%   +0.01%     
==========================================
  Files         933      933              
  Lines       85285    85281       -4     
==========================================
+ Hits         9933     9945      +12     
+ Misses      74223    74203      -20     
- Partials     1129     1133       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Aug 5, 2024
@realshuting realshuting enabled auto-merge (squash) August 9, 2024 10:21
@realshuting realshuting merged commit 65a43d2 into kyverno:main Aug 9, 2024
259 of 260 checks passed
aerosouund pushed a commit to aerosouund/kyverno that referenced this pull request Aug 28, 2024
* feat(mutate): minimize unmarshals

Signed-off-by: Khaled Emara <[email protected]>

* test(mutate): test type assertion

Signed-off-by: Khaled Emara <[email protected]>

* chore(codegen): remove unused import

Signed-off-by: Khaled Emara <[email protected]>

---------

Signed-off-by: Khaled Emara <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
milestone 1.13.0 performance size:M This PR changes 30-99 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants