-
Notifications
You must be signed in to change notification settings - Fork 917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: get ns labels in the cluster mode when using the CLI #10348
Conversation
94e27b8
to
5d298e1
Compare
Signed-off-by: Mariam Fahmy <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10348 +/- ##
==========================================
+ Coverage 10.03% 10.22% +0.19%
==========================================
Files 1038 1031 -7
Lines 93760 91915 -1845
==========================================
- Hits 9405 9397 -8
+ Misses 83323 81489 -1834
+ Partials 1032 1029 -3 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Mariam Fahmy <[email protected]>
Co-authored-by: shuting <[email protected]> Signed-off-by: Mariam Fahmy <[email protected]>
/cherry-pick release-1.12 |
Base branch was modified
Cherry-pick failed with |
with main branch, I built the cli and checked with the resources you have used in test:
polex
pod
ns
output:
Am I missing something? |
You have to pass exceptions through the
The output is as follows:
|
I see in the release-1.12 branch it isnt working, I understand this wasnt cherrypicked in 1.12.4? |
) * fix: get ns labels in the cluster mode when using the CLI Signed-off-by: Mariam Fahmy <[email protected]> * chore: fix chainsaw test Signed-off-by: Mariam Fahmy <[email protected]> * Update .vscode/launch.json Co-authored-by: shuting <[email protected]> Signed-off-by: Mariam Fahmy <[email protected]> --------- Signed-off-by: Mariam Fahmy <[email protected]> Signed-off-by: Mariam Fahmy <[email protected]> Co-authored-by: shuting <[email protected]>
…#10348) (#10549) * fix: get ns labels in the cluster mode when using the CLI Signed-off-by: Mariam Fahmy <[email protected]> * chore: fix chainsaw test Signed-off-by: Mariam Fahmy <[email protected]> --------- Signed-off-by: Mariam Fahmy <[email protected]>
Explanation
This PR gets the namespace labels for the resource in the CLI when it has the ability to connect to the cluster (i.e.
--cluster
flag is used)Related issue
Closes #10260
Milestone of this PR
/milestone 1.12.4
Documentation (required for features)
My PR contains new or altered behavior to Kyverno.
What type of PR is this
/kind bug
Proposed Changes
Proof Manifests
Checklist
Further Comments