Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

corrected comment #284

Merged
merged 2 commits into from
Feb 1, 2024
Merged

corrected comment #284

merged 2 commits into from
Feb 1, 2024

Conversation

swastik959
Copy link
Contributor

@swastik959 swastik959 commented Jan 26, 2024

Explanation

missing a comment in the code snippit in the usage section . about creating a new json engine

Related issue

closes #283

Milestone of this PR

What type of PR is this

/kind bug

Proposed Changes

Proof Manifests

Checklist

  • I have read the contributing guidelines.
  • I have read the PR documentation guide and followed the process including adding proof manifests to this PR.
  • This is a bug fix and I have added unit tests that prove my fix is effective.
  • This is a feature and I have added CLI tests that are applicable.
  • My PR needs to be cherry picked to a specific release branch which is .

Further Comments

Signed-off-by: swastik959 <[email protected]>
@eddycharly eddycharly enabled auto-merge (squash) February 1, 2024 10:40
Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (da28742) 21.70% compared to head (e0bef3e) 21.70%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #284   +/-   ##
=======================================
  Coverage   21.70%   21.70%           
=======================================
  Files          31       31           
  Lines        2258     2258           
=======================================
  Hits          490      490           
  Misses       1742     1742           
  Partials       26       26           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eddycharly eddycharly merged commit f622e65 into kyverno:main Feb 1, 2024
33 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] missing a comment in the code snippit in the usage section
2 participants