Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Update complex join example to better illustrate the options available (symmetry with where) #883

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

MarkusWendorf
Copy link
Contributor

Hello,

when I read the docs I failed to understand how to do OR expressions.

You can do all the same things with the
on method that you can with the corresponding where method

The hint at the where documentation was not sufficient for me (that's more a me issue though).

So I included a little more information about the options provided by on.

Copy link

vercel bot commented Feb 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
kysely ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 14, 2024 11:42am

@koskimas
Copy link
Member

koskimas commented Feb 14, 2024

Those files you modified are automatically generated from the comments in the source code. You need to:

  1. Modify the example in the code coments
  2. Build using npm run build
  3. Run this script to generate the example files for kysely.dev.

@MarkusWendorf
Copy link
Contributor Author

Ok got it. The script is using lodash which was not present in the package.json. I added it as a dev dependency, if that's alright.

Copy link
Member

@koskimas koskimas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@koskimas koskimas merged commit 573ee72 into kysely-org:master Feb 14, 2024
4 checks passed
@igalklebanov igalklebanov added the documentation Improvements or additions to documentation label Mar 11, 2024
thecodrr pushed a commit to thecodrr/kysely that referenced this pull request Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants