fix errors for contributors on Windows #747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
I use WSL2, so I never had this issue. |
igalklebanov
added
ready for review
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scripts/module-fixup.js
Since node 'path' module uses platform specific path separator, git-ignored
helpers/files could be generated with escape character\:export * from '..\dist\cjs\helpers\postgres.js'Updated
path->path.posixto use/as path separator always.New dev-dependency
cross-env: for setting environment variables regardless of platform while testing.
I found this errors recently by moving primary OS from Ubuntu to Windows.
I can't completly sure this is Windows-related because it's hard to believe that out of 71 contributors, none of them use Windows.