Mssql docs

[gittgott]

closes #713

I couldn't get deno or bun to work with the dialect. Deno was having issues connecting to the database with the message Error: Failed to connect to localhost:1433 - tlssock._start is not a function. Bun was having issues with tarn with the message Failed to connect to localhost:1433 - socket must be an instance of net.Socket.

Since this wasn't working for me, I stated that bun and deno didn't support the mssql dialect in the docs. Just want to make sure that they aren't currently known to work.

Thanks!

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
kysely	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 31, 2023 0:20am

[igalklebanov]

Hey 👋

Thanks! 💪

Let some initial comments..

[igalklebanov]

We need to somehow mention that it also uses Tarn for connection pool management and provide a link to tarn's documentation.
https://github.com/kysely-org/kysely/pull/724/files#diff-f8ce7b5d9b471415c6e85f9db24baf58b16c5a55101d354bf66c0dc497340671R105-R109

[igalklebanov]

Regarding Deno compatibility, here's an official issue that seems related to the problem (and someone claimed it still doesn't work 2 weeks ago despite being closed).

[igalklebanov]

Regarding Bun compatibility, here's an issue that seems related to the problem (all commenters use libraries that use tedious under the hood).

[gittgott]

Hey @igalklebanov
I should have everything covered that you brought up.

Thanks for all your work maintaining this library by the way. You all do an amazing job.
I'm quite ecstatic that mssql is becoming part of the core dialects.

[igalklebanov]

Looks good!

Just a small correction..

[igalklebanov]

something's missing in "getting started -> querying".

[sofanati-nour]

something's missing in "getting started -> querying".

it's the dialectSpecificCodeSnippets missing a mssql entry in getting-started/Querying.tsx

[gittgott]

Hey @igalklebanov,

Sorry about that. I ran into some issues getting that one to work and forgot about it (and didn't run typecheck 🤦‍♂️)

I meant to ask: what would be a preferable solution for inserting a new row and returning data from that inserted row while #687 is still open?
The only thought I had was to use that existing findPeople function and grab the last value of the array that's returned. Here's the snippet for that:

export async function createPerson(person: NewPerson) {
  await db.insertInto('person')
    .values(person)
    .executeTakeFirstOrThrow()

  const newPerson = (await findPeople(person)).at(-1)
  return newPerson
}

export async function deletePerson(id: number) {
  const person = await findPersonById(id)

  if (person) {
    await db.deleteFrom('person').where('id', '=', id).execute()
  }

  return person
}

I think that the data will be sorted by id, so this would grab the most recently inserted row, but there would be issues if something was inserted to the table with identical values between the execution of the insertInto line and newPerson line.

Am I missing something or would there be no better option until the output clause is supported?

[igalklebanov]

@gittgott I'd prefer using scope identity in a transaction.