Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add any function to the function module #612

Merged
merged 3 commits into from
Jul 24, 2023
Merged

Add any function to the function module #612

merged 3 commits into from
Jul 24, 2023

Conversation

koskimas
Copy link
Member

Closes #593

@koskimas koskimas requested a review from igalklebanov July 23, 2023 09:20
@vercel
Copy link

vercel bot commented Jul 23, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
kysely ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 24, 2023 7:43am

@koskimas koskimas changed the title Add any function to the function module Add any function to the function module Jul 23, 2023
igalklebanov
igalklebanov previously approved these changes Jul 23, 2023
View reviewed changes
Copy link
Member

@igalklebanov igalklebanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@igalklebanov igalklebanov added enhancement New feature or request postgres Related to PostgreSQL api Related to library's API breaking change Includes breaking changes labels Jul 23, 2023
@igalklebanov igalklebanov dismissed their stale review July 23, 2023 21:53

missing mysql tests.

igalklebanov
igalklebanov reviewed Jul 23, 2023
View reviewed changes
Copy link
Member

@igalklebanov igalklebanov left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing some MySQL tests.

@igalklebanov igalklebanov added the mysql Related to MySQL label Jul 23, 2023
@koskimas
Copy link
Member Author

koskimas commented Jul 24, 2023 •
edited
Loading

Oh crap. The MySQL syntax probably won't work on Postgres.

@koskimas
Copy link
Member Author

Oh crap. The MySQL syntax probably won't work on Postgres.

It did work 😅. @igalklebanov I've added a test for a subquery any. Nice catch!

igalklebanov
igalklebanov approved these changes Jul 24, 2023
View reviewed changes
Copy link
Member

@igalklebanov igalklebanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go! 🚀

@igalklebanov igalklebanov merged commit 7cc4530 into master Jul 24, 2023
@igalklebanov igalklebanov deleted the add-any-function branch July 24, 2023 10:49
@maccman
Copy link

maccman commented Aug 26, 2023

@koskimas @igalklebanov I can't get this working on Generated columns.

CleanShot 2023-08-26 at 09 19 01@2x

Works on a straight string[] column though.

Gaspero pushed a commit to Gaspero/kysely that referenced this pull request Oct 2, 2023
@koskimas @Gaspero
Add any function to the function module (kysely-org#612)
79fc0d2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igalklebanov igalklebanov igalklebanov approved these changes

Assignees
No one assigned
Labels
api Related to library's API breaking change Includes breaking changes enhancement New feature or request mysql Related to MySQL postgres Related to PostgreSQL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] Support for ANY/SOME array function/comparison
3 participants
@koskimas @maccman @igalklebanov