Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add databases section @ site home page. #531

Closed

Conversation

igalklebanov
Copy link
Member

@igalklebanov igalklebanov commented Jun 11, 2023

image

Need to host the logos instead of using external URLs, other than that, pretty much done.

Logos order:

  1. core dialects.
  2. by revenue / funds raised - as a way to guess market share / marketing power.
  3. by github stars.

@igalklebanov igalklebanov added the documentation Improvements or additions to documentation label Jun 11, 2023
@vercel
Copy link

vercel bot commented Jun 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
kysely ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2024 11:30pm

@fhur
Copy link
Collaborator

fhur commented Jun 26, 2023

Very cool. Some thoughts:

  1. Would be useful if the the blocks were clickable (e.g. click on planetscale sends you to the planetscale docs, in another window, so we don't lose the session)
  2. With regards to copy, what do you think of "official dialect" as opposed to "core dialect"?
  3. Some of the icons lack contrast (e.g. mysql). This will need a bit of design work. If you're not sure how to fix I'll be happy to give you a hand.

Also if you want I can take over the branch and do the remaining changes :)

@igalklebanov
Copy link
Member Author

@fhur

Good ideas! Also, we should probably optimize loading of these images, I lazily copied and used external urls for this PoC.

I think "official" might confuse people. e.g. thinking that we have an official Supabase dialect.

Sent you an invite.

@igalklebanov
Copy link
Member Author

Also, "official" sheds a negative light on "community".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants