Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added column type binary(${number}) #463

Merged
merged 2 commits into from
May 6, 2023
Merged

Added column type binary(${number}) #463

merged 2 commits into from
May 6, 2023

Conversation

neographer
Copy link
Contributor

closes #421

@vercel
Copy link

vercel bot commented May 5, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
kysely ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 5, 2023 8:41pm

@igalklebanov igalklebanov added typescript Related to Typescript api Related to library's API enhancement New feature or request mysql Related to MySQL labels May 5, 2023
igalklebanov
igalklebanov requested changes May 5, 2023
View reviewed changes
Copy link
Member

@igalklebanov igalklebanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey 👋

Thank you! ❤️

Looks good! Let's add it where applicable in tests.

@neographer
Copy link
Contributor Author

Hey 👋

Thank you! ❤️

Looks good! Let's add it where applicable in tests.

Added tests.

igalklebanov
igalklebanov approved these changes May 6, 2023
View reviewed changes
Copy link
Member

@igalklebanov igalklebanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@igalklebanov igalklebanov merged commit b77cd79 into kysely-org:master May 6, 2023
@neographer neographer deleted the issue-421 branch May 17, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igalklebanov igalklebanov igalklebanov approved these changes

Assignees
No one assigned
Labels
api Related to library's API enhancement New feature or request mysql Related to MySQL typescript Related to Typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing column type binary(${number}) for mysql
2 participants
@neographer @igalklebanov