Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add deleteQueryBuilder.returningAll(table) overload (#268) #314

Merged
merged 4 commits into from
Mar 6, 2023
Merged

feat: add deleteQueryBuilder.returningAll(table) overload (#268) #314

merged 4 commits into from
Mar 6, 2023

Conversation

anirudh1713
Copy link
Contributor

closes #268

igalklebanov
igalklebanov requested changes Feb 4, 2023
View reviewed changes
Copy link
Member

@igalklebanov igalklebanov left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 💪

LGTM! Check the comments/suggestions (nitpicky ones are non-blocking).. feel free to dismiss the review and hit the re-request review button when you're ready. Also feel free to @me on discord if you need help!

test/node/src/delete.test.ts Outdated Show resolved Hide resolved
test/node/src/delete.test.ts Outdated Show resolved Hide resolved
test/node/src/delete.test.ts Show resolved Hide resolved
test/typings/test-d/delete-query-builder.test-d.ts Outdated Show resolved Hide resolved
src/query-builder/returning-interface.ts Outdated Show resolved Hide resolved
test/node/src/delete.test.ts Show resolved Hide resolved
src/query-builder/delete-query-builder.ts Outdated Show resolved Hide resolved
@igalklebanov igalklebanov added enhancement New feature or request postgres Related to PostgreSQL api Related to library's API labels Feb 6, 2023
@anirudh1713 anirudh1713 force-pushed the feat/delete-query-builder-returning-all branch from 1a3842d to dd2e032 Compare February 13, 2023 10:47
igalklebanov
igalklebanov approved these changes Feb 15, 2023
View reviewed changes
Copy link
Member

@igalklebanov igalklebanov left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 💪
Just a few minor typos..

src/query-builder/delete-query-builder.ts Outdated Show resolved Hide resolved
src/query-builder/delete-query-builder.ts Show resolved Hide resolved
@anirudh1713 anirudh1713 force-pushed the feat/delete-query-builder-returning-all branch from d531c37 to 5aeef4c Compare February 17, 2023 14:27
koskimas
koskimas approved these changes Mar 6, 2023
View reviewed changes
Copy link
Member

@koskimas koskimas left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice! Sorry for the delay. Been super busy at work.

@koskimas koskimas merged commit 5b48fc8 into kysely-org:master Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igalklebanov igalklebanov igalklebanov approved these changes

@koskimas koskimas koskimas approved these changes

Assignees
No one assigned
Labels
api Related to library's API enhancement New feature or request postgres Related to PostgreSQL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add DeleteQueryBuilder.returningAll(table) overload.
3 participants
@anirudh1713 @koskimas @igalklebanov