Keep column order same as ordinal_position. #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@koskimas |
|
I think this is fine. The user can always sort the list by name. |
koskimas
force-pushed
the
column_order
branch
from
69ceb70 to
1c61026
Compare
RobinBlomberg
added a commit
to RobinBlomberg/kysely-codegen
that referenced
this pull request
Jan 2, 2023
- This upgrades Kysely, so the generated column order is no longer alphabetical (see kysely-org/kysely#262)
igalklebanov
added
breaking change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related #146