Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(alter-table): support multiple column operations #238

Conversation

naorpeled
Copy link
Contributor

@naorpeled naorpeled commented Nov 25, 2022

  • feat(alter-table-node)!: allow multiple alter ops - allow multiple column alterations at AlterTableNode
  • def-query-compiler: align /w AlterTableNode
  • operation-node-transformer align /w AlterTableNode
  • add alter column builder
  • remove usages of ColumnDefinitionBuilderInterface
  • allow multiple col alterations@alter-table-builder
  • rename schema alterTable prop
  • added alter-column-builder to index
  • added and fixed unit tests

co authored by @igalklebanov
closes #217

@igalklebanov igalklebanov added api Related to library's API breaking change Includes breaking changes enhancement New feature or request labels Nov 25, 2022
@naorpeled naorpeled force-pushed the feat/alter-table/support-multiple-add-column branch from ef0a9ba to 56ee78f Compare November 25, 2022 22:16
@koskimas
Copy link
Member

koskimas commented Nov 28, 2022

This looks really good! Sorry it's taking me a long time again. I'll try to review this thoroughly this week.

@koskimas koskimas merged commit 458b3c0 into kysely-org:master Dec 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Related to library's API breaking change Includes breaking changes enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support multiple column ALTER TABLE.
3 participants