Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: trim sql row to remove leading whitespace or newline #236

Conversation

tobiasfoerg
Copy link
Contributor

Fixes #235

@koskimas
Copy link
Member

Thanks! Fix the indentation and this is good to go

@igalklebanov igalklebanov added bug Something isn't working sqlite Related to sqlite built-in dialect Related to a built-in dialect labels Nov 25, 2022
@koskimas koskimas force-pushed the tfoerg--sqlite-introspection-autoincrement branch from bbeeb87 to 1b88633 Compare November 26, 2022 11:24
@koskimas koskimas force-pushed the tfoerg--sqlite-introspection-autoincrement branch from 1b88633 to 64002c0 Compare December 3, 2022 12:48
@koskimas koskimas merged commit d67b161 into kysely-org:master Dec 4, 2022
@tobiasfoerg tobiasfoerg deleted the tfoerg--sqlite-introspection-autoincrement branch December 15, 2022 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working built-in dialect Related to a built-in dialect sqlite Related to sqlite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: sqlite introspection does not detect autoincrement column when sql contains newlines
3 participants