Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exactOptionalPropertyTypes should no longer error when updating/inserting with undefined values in nullable columns. #210

Merged
merged 2 commits into from
Oct 30, 2022
Merged

exactOptionalPropertyTypes should no longer error when updating/inserting with undefined values in nullable columns. #210

merged 2 commits into from
Oct 30, 2022

Conversation

igalklebanov
Copy link
Member

@igalklebanov igalklebanov commented Oct 29, 2022 •
edited
Loading

2nd attempt at closing #170 . #171 missed the mark, changing things deeper than needed.

@igalklebanov igalklebanov added api Related to library's API enhancement New feature or request typescript Related to Typescript labels Oct 29, 2022
@igalklebanov igalklebanov requested a review from koskimas October 29, 2022 21:15
koskimas
koskimas approved these changes Oct 30, 2022
View reviewed changes
Copy link
Member

@koskimas koskimas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@koskimas koskimas merged commit 233377b into kysely-org:master Oct 30, 2022
@bestickley
Copy link
Contributor

Thank you!

@igalklebanov igalklebanov deleted the fix-170 branch November 1, 2022 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koskimas koskimas koskimas approved these changes

Assignees
No one assigned
Labels
api Related to library's API enhancement New feature or request typescript Related to Typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@igalklebanov @bestickley @koskimas