Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix no separator between default insert values. #202

Merged
merged 3 commits into from
Oct 22, 2022
Merged

fix no separator between default insert values. #202

merged 3 commits into from
Oct 22, 2022

Conversation

igalklebanov
Copy link
Member

Currently, having more than 1 missing column value in insertInto value compiles to:

("hello", "world", nullnull)

instead of

("hello", "world", null, null)

@igalklebanov igalklebanov added the bug Something isn't working label Oct 22, 2022
@igalklebanov igalklebanov requested a review from koskimas October 22, 2022 09:17
koskimas
koskimas approved these changes Oct 22, 2022
View reviewed changes
Copy link
Member

@koskimas koskimas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find!

@koskimas koskimas merged commit 3f91374 into kysely-org:master Oct 22, 2022
@igalklebanov igalklebanov deleted the fix-default-insert branch October 22, 2022 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koskimas koskimas koskimas approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@igalklebanov @koskimas