make FunctionModule's avg, max, min & sum functions nullable (consumer opt-in).
#183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igalklebanov
changed the title
FunctionModules's avg, max, min & sum to null return value.FunctionModule's avg, max, min & sum to null return value.
igalklebanov
changed the title
FunctionModule's avg, max, min & sum to null return value.FunctionModule's avg, max, min & sum functions to null return value.
igalklebanov
commented
Oct 6, 2022
igalklebanov
commented
Oct 6, 2022
igalklebanov
changed the title
FunctionModule's avg, max, min & sum functions to null return value.FunctionModule's avg, max, min & sum nullable (consumer opt-in).
igalklebanov
changed the title
FunctionModule's avg, max, min & sum nullable (consumer opt-in).FunctionModule's avg, max, min & sum functions nullable (consumer opt-in).
koskimas
reviewed
Oct 17, 2022
koskimas
reviewed
Oct 17, 2022
koskimas
reviewed
Oct 17, 2022
|
Sorry about docs, hope its fine now.. 😅 |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These aggregate functions are nullable, in some edge cases.
Current types:
a. are a lie, if some edge cases are possible in consumer's queries / state of database.
b. do not allow our consumers to state
nullas a possible return type.Let's help our consumers write robust code, by allowing them to opt-in for the stricter nullable form.
Should fit smooth like 🧈 with recently merged
.coalesce(...)function.